Adding ServiceBus Trigger Changes #353
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR extends fromRpcTypedData to handle the collectionModelBindingData case and adds comprehensive tests for this new path.
- Implements a new branch in
fromRpcTypedDatato create clients fromcollectionModelBindingData - Adds unit tests covering valid, edge, and error scenarios for
collectionModelBindingData - Ensures fallback behavior remains unchanged
Reviewed Changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/converters/fromRpcTypedData.ts | Added else if branch for collectionModelBindingData handling and error wrapping |
| test/converters/fromRpcTypedData.test.ts | Introduced tests for successful client creation, undefined source, thrown errors, and non-Error exceptions in the new path |
Comment on lines
+45
to
+51
| } else if (data.collectionModelBindingData && isDefined(data.collectionModelBindingData.modelBindingData)) { | ||
| try { | ||
| const resourceFactoryResolver: ResourceFactoryResolver = ResourceFactoryResolver.getInstance(); | ||
| // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-unsafe-call | ||
| return resourceFactoryResolver.createClient( | ||
| data?.collectionModelBindingData?.modelBindingData[0]?.source, | ||
| data?.collectionModelBindingData?.modelBindingData |
There was a problem hiding this comment.
[nitpick] Consider validating that modelBindingData is non-empty before accessing the first element. If the array is empty, calling createClient with an undefined source may lead to unintended behavior.
Suggested change
| } else if (data.collectionModelBindingData && isDefined(data.collectionModelBindingData.modelBindingData)) { | |
| try { | |
| const resourceFactoryResolver: ResourceFactoryResolver = ResourceFactoryResolver.getInstance(); | |
| // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-unsafe-call | |
| return resourceFactoryResolver.createClient( | |
| data?.collectionModelBindingData?.modelBindingData[0]?.source, | |
| data?.collectionModelBindingData?.modelBindingData | |
| } else if ( | |
| data.collectionModelBindingData && | |
| isDefined(data.collectionModelBindingData.modelBindingData) && | |
| data.collectionModelBindingData.modelBindingData.length > 0 | |
| ) { | |
| try { | |
| const resourceFactoryResolver: ResourceFactoryResolver = ResourceFactoryResolver.getInstance(); | |
| // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-unsafe-call | |
| return resourceFactoryResolver.createClient( | |
| data.collectionModelBindingData.modelBindingData[0].source, | |
| data.collectionModelBindingData.modelBindingData |
Copilot uses AI. Check for mistakes.
swapnil-nagar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for the autoCompleteMessages configuration option to Service Bus triggers, allowing developers to control whether messages are automatically completed after successful processing.
Background
Currently, the Service Bus trigger in Azure Functions for Node.js lacks explicit control over message completion behavior. This enhancement brings parity with other Azure Functions runtimes by introducing the autoCompleteMessages option that was already defined in the TypeScript definitions but not fully implemented.
Changes Made
Type Definitions (already present)
ServiceBusQueueTriggerOptions.autoCompleteMessages?: boolean - Controls automatic message completion for queue triggers
Enhanced JSDoc documentation referencing official Azure documentation